Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to exclude Docker's persistence directory #1057

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Yannick243
Copy link
Member

@Yannick243 Yannick243 commented Jun 3, 2024

Docker's persistence folder (data) was not being ignored.

This is a small update to #1001

@Yannick243 Yannick243 changed the title Update .gitignore to exclude Docker's data directory Update .gitignore to exclude Docker's persistence directory Jun 3, 2024
@marclaporte marclaporte requested a review from jonocodes June 3, 2024 20:26
@jonocodes
Copy link
Contributor

How are you running docker exactly? Are you running the sample yaml file directly in the docker directory perhaps?
Are you running this in production or development?

@Yannick243 Yannick243 force-pushed the docker-ignore-data branch from 754ab75 to 556ac02 Compare June 4, 2024 06:33
@Yannick243
Copy link
Member Author

My bad, i was running it directly in the docker directory.

@Yannick243
Copy link
Member Author

Hello @jonocodes;
I think this is this still relevant, as some people may run Docker directly from the Docker directory? Or am I mistaken?

@jonocodes
Copy link
Contributor

Hello @jonocodes; I think this is this still relevant, as some people may run Docker directly from the Docker directory? Or am I mistaken?

I didnt think of that use case, but yeah it can be relevant since it may be a way people use it.
I am considering changing the name of the file to docker-compose.prodexample.yaml to make it a little more clear also.

@marclaporte
Copy link
Member

So what is the next step?

@jonocodes
Copy link
Contributor

I approved it. It can be merged.

@marclaporte marclaporte merged commit a053782 into cypht-org:master Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants